Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds ENDED AdGroup status #803

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

mayan-jbsmith
Copy link
Contributor

No description provided.

…oupServingStatus type to handle the same undocumented cases
…paignServingStatus type to handle the same undocumented cases
@moltar
Copy link
Contributor

moltar commented Jul 30, 2021

@mayan-jbsmith thanks for your contribution. Everything looks good, except one small thing. There is a listing error. Please run a linter fix: npm run lint:fix. Thanks!

@moltar moltar changed the title Feat/update campaign and adgroups type edgecases fix: adds ENDED AdGroup status Jul 30, 2021
@mayan-jbsmith
Copy link
Contributor Author

@moltar got the linting resolved but have some long commit messages. Thanks.

@mayan-jbsmith
Copy link
Contributor Author

@moltar just let me know if I need to revise the commit messages as well.

@moltar moltar merged commit e56f46b into ScaleLeap:master Jul 30, 2021
github-actions bot pushed a commit that referenced this pull request Jul 30, 2021
## [3.1.19](v3.1.18...v3.1.19) (2021-07-30)

### Bug Fixes

* adds ENDED AdGroup status ([#803](#803)) ([e56f46b](e56f46b))
@mayan-jbsmith mayan-jbsmith deleted the feat/update-campaign-types-edgcases branch July 30, 2021 05:22
@github-actions
Copy link

🎉 This PR is included in version 3.1.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants